These are good codes as i find them easy to understand. Though you indicated you dint consider the idea of OOP, i think it would be better if they were in classes which we can extend instead of interfering in what you've already done or having to repeat the functions all over again in process of modification. On Sun, Jul 26, 2009 at 9:29 PM, Chris Mwirigi <mwirigic@gmail.com> wrote:
Hi Peter, Nice collection u got there i have a few concerns though.
1. Presentation is not seperated from logic. I have seen lots of <tr>'s , <td>'s and <selects> in the functions. This makes the functions not generic especially for some of us who never use tables for layout. 2. Printing out the mysql_error() is not a good idea, as it might expose your underlying db schema to the world. i would suggest you log the error in file as opposed to printing it out. 3. Interaction with the Data layer is not abstracted. Ur functions assume that DB will always be MYSQL, if e.g. u get a project that uses Oracle, it will mean that most of the functions will have to be rewritten.
On Sun, Jul 26, 2009 at 4:16 PM, Peter Karunyu<pkarunyu@gmail.com> wrote:
Hi skunks, I've been working with PHP for a little while now and in that time, I've collected some of the functions I've written which I use in almost all of the projects I work on.
I've cleaned them a bit and made them a more developer friendly, with generous comments.
Maybe they can save someone a few hours of writing code, as they have for me.
Any comments, criticisms, additions, modifications etc are welcome.
Regards, Peter.
_______________________________________________ Skunkworks mailing list Skunkworks@lists.my.co.ke http://lists.my.co.ke/cgi-bin/mailman/listinfo/skunkworks Other services @ http://my.co.ke Other lists ------------- Announce: http://lists.my.co.ke/cgi-bin/mailman/listinfo/skunkworks-announce Science: http://lists.my.co.ke/cgi-bin/mailman/listinfo/science kazi: http://lists.my.co.ke/cgi-bin/mailman/admin/kazi/general
_______________________________________________ Skunkworks mailing list Skunkworks@lists.my.co.ke http://lists.my.co.ke/cgi-bin/mailman/listinfo/skunkworks Other services @ http://my.co.ke Other lists ------------- Announce: http://lists.my.co.ke/cgi-bin/mailman/listinfo/skunkworks-announce Science: http://lists.my.co.ke/cgi-bin/mailman/listinfo/science kazi: http://lists.my.co.ke/cgi-bin/mailman/admin/kazi/general